Skip to content

Fixes nuttx target warning #4984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fixes nuttx target warning #4984

merged 1 commit into from
Dec 17, 2024
+2 −8

Conversation

@lygstate
Copy link
Contributor

@lygstate lygstate commented Feb 10, 2022 

jerry-main.c: In function 'str_to_uint':
jerry-main.c:89:12: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   89 |     *out_p = num_str_p;
make[4]: Leaving directory '/home/runner/work/jerryscript/jerryscript/targets/os/nuttx'
make[3]: Leaving directory '/home/runner/work/jerryscript/apps'

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]

@rtakacs
Copy link
Contributor

rtakacs commented Feb 22, 2022

Good catch! I think, it's better to remove that parameter since str_to_num is used only once at jerry-main.c:179 with NULL argument for out_p.

@rtakacs
Copy link
Contributor

rtakacs commented Mar 2, 2022

LGTM (informal)

robertsipka
robertsipka approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ossy-szeged
ossy-szeged previously requested changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@ossy-szeged ossy-szeged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be great to have a formal commit message, we don"t put complete build logs to the commit messages.

@lygstate lygstate closed this Nov 13, 2024
@lygstate lygstate deleted the nuttx-warning branch November 13, 2024 19:14
@lygstate lygstate restored the nuttx-warning branch December 11, 2024 07:39
@lygstate lygstate reopened this Dec 11, 2024
@lygstate
Fixes nuttx target warning
6358606 
The warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]
@lygstate
Copy link
Contributor Author

lygstate commented Dec 11, 2024

Closed by accident, @ossy-szeged updated and rebased

robertsipka
robertsipka approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango dismissed ossy-szeged’s stale review December 17, 2024 09:17

Requested change has been done

@LaszloLango LaszloLango merged commit f322f60 into jerryscript-project:master Dec 17, 2024
26 checks passed
@lygstate lygstate deleted the nuttx-warning branch December 17, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertsipka robertsipka robertsipka approved these changes

@LaszloLango LaszloLango LaszloLango approved these changes

@ossy-szeged ossy-szeged Awaiting requested review from ossy-szeged

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lygstate @rtakacs @ossy-szeged @robertsipka @LaszloLango